today I did this but since I am a beginner I ask for advice